[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

This revision was automatically updated to reflect the committed changes. Closed by commit rL366818: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Looks good! Sorry for the delay :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64241/new/ https://reviews.llvm.org/D64241 ___

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

martong added a comment. @a_sidorin This is a polite Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64241/new/ https://reviews.llvm.org/D64241 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

martong added a comment. In D64241#1584972 , @a_sidorin wrote: > Hi Gabor, > This looks fine, but could you please add a test showing how decl shadowing > is handled? I.e. if we have Arg in one TU and both Arg and N::Arg in another > TU. Alexei, Than

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

martong updated this revision to Diff 210581. martong added a comment. - Add test case ClassTemplSpecWithInequivalentShadowedTemplArg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64241/new/ https://reviews.llvm.org/D64241 Files: clang/lib/AST/A

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

a_sidorin added a comment. Hi Gabor, This looks fine, but could you please add a test showing how decl shadowing is handled? I.e. if we have Arg in one TU and both Arg and N::Arg in another TU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64241/ne

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. We falsely state inequivalence if the template parameter is a qualified/nonquialifie