[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:427 } + // Deduplicate clang-tidy diagnostics -- some clang-tidy checks may emit + // duplicated messages due to various reasons (e.g. the check doesn'

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365204: [clangd] Deduplicate clang-tidy diagnostic messages. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:427 } + // Deduplicate clang-tidy diagnostics -- some clang-tidy checks may emit + // duplicated messages

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

hokein updated this revision to Diff 208158. hokein marked 2 inline comments as done. hokein added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64127/new/ https://reviews.llvm.org/D64127 Files: clang-tools-extra/clan

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:427 } + // Deduplicate clang-tidy diagnostics -- some clang-tidy checks may emit + // duplicated messages due to various reasons (e.g. the check doesn't handle sammccall wrote

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:427 } + // Deduplicate clang-tidy diagnostics -- some clang-tidy checks may emit + // duplicated messages due to various reasons (e.g. the check doesn't handle This sorting

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

hokein updated this revision to Diff 207760. hokein added a comment. Revert the LSPDiagnosticCompare change in rL363889 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64127/new/ https://reviews.llvm.org/D64127

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

hokein added a comment. In D64127#1568093 , @kadircet wrote: > Could you also revert changes in `LSPDiagnosticCompare` in `Protocol.h`, that > were introduced by rL363889 ? (or bring > back `fixits-duplication.test`)

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

kadircet added a comment. Could you also revert changes in `LSPDiagnosticCompare` in `Protocol.h`, that were introduced by rL363889 ? (or bring back `fixits-duplication.test`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Clang-tidy checks may emit duplicated messages (clang-tidy tool deduplicate them in its custom diagnostic consume