[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru updated this revision to Diff 209474. sylvestre.ledru added a comment. Actually remove it Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 Files: docs/LanguageExtensions.rst docs/ReleaseNotes.rst lib/

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru updated this revision to Diff 209473. sylvestre.ledru added a comment. Keep -dumpversion Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 Files: docs/ClangCommandLineReference.rst docs/LanguageExtension

[PATCH] D64062: Remove both -dumpversion and __VERSION__

rnk added a comment. In D64062#1581662 , @sylvestre.ledru wrote: > In D64062#1581290 , @rnk wrote: > > > Perhaps we should just remove `__VERSION__` and keep `-dumpversion`. > > > As you wish. clang --version seems

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. In D64062#1581290 , @rnk wrote: > Perhaps we should just remove `__VERSION__` and keep `-dumpversion`. As you wish. clang --version seems an alternative and dumpversion never //worked// for clang. so, I don't expect soft

[PATCH] D64062: Remove both -dumpversion and __VERSION__

rnk added a comment. I still have this open concern: In D64062#1574868 , @rnk wrote: > One concern that I have is that we don't have a replacement for > `-dumpversion`. I thought I saw someone propose adding such a flag, but I > can't find it. Basically

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. @rnk Works for you? I would like to land that before the 9 branch. Thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 ___ cfe-commits mail

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru updated this revision to Diff 208619. sylvestre.ledru added a comment. Update of the release note. thanks to @rnk for the suggestion Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 Files: docs/ClangComma

[PATCH] D64062: Remove both -dumpversion and __VERSION__

rnk added a comment. In D64062#1567175 , @sylvestre.ledru wrote: > This isn't firefox per say but thirdparty apps. > If you feel confident, sure, we can land that and see what happens :) One concern that I have is that we don't have a replacement for `

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. @rnk is it good for you ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. This isn't firefox per say but thirdparty apps. If you feel confident, sure, we can land that and see what happens :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062

[PATCH] D64062: Remove both -dumpversion and __VERSION__

rnk added a comment. But, based on the github search, I don't think we could reasonably change dumpversion to print 8.0.0, so I'm not sure it really matters. Firefox builds with clang these days, so I'm not sure what they could possibly be using -dumpversion for that would matter. Repository:

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. Actually, I don't think removing -dumpversion is a great idea. it will remove the capability of clang to be a dropped in replacement. I see a lot of occurrences: https://github.com/search?q=%22-dumpversion%22&type=Code https://codesearch.debian.net/search?q=%22-d

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: rnk, dexonsmith. Herald added subscribers: cfe-commits, arphaman, fedor.sergeev, aheejin, dschuff. Herald added a project: clang. It has been introduced in 2011 for gcc compat: https://github.com/llvm-mirror/clang/commit/95a9