[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365666: [clang] Preserve names of addrspacecast'ed values. (authored by vzakhari, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-co

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. I changed the tests to use FileCheck variables whenever possible. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari updated this revision to Diff 208564. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGenCUDA/builtins-amdgcn.cu clang/test/CodeGenOpenCL/address-spaces-conversions.cl clang/t

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

rjmccall added a comment. In D63846#1574311 , @vzakhari wrote: > In D63846#1574302 , @rjmccall wrote: > > > I don't know what I think about widespread use of > > `-fno-discard-value-names` for now; please continue

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. In D63846#1574302 , @rjmccall wrote: > I don't know what I think about widespread use of `-fno-discard-value-names` > for now; please continue to use FileCheck variables, and we can make a > holistic decision about that flag lat

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

rjmccall added a comment. I don't know what I think about widespread use of `-fno-discard-value-names` for now; please continue to use FileCheck variables, and we can make a holistic decision about that flag later. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari marked an inline comment as done. vzakhari added a comment. In D63846#1574102 , @rjmccall wrote: > Please don't check IR names in test output. That actually includes anonymous > names like `%2`; these should always be tested with FileCheck varia

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

rjmccall added a comment. Please don't check IR names in test output. That actually includes anonymous names like `%2`; these should always be tested with FileCheck variables. I suggest using `%.*` as the pattern; if you're matching the LHS of an LLVM assignment, that shouldn't have problems

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

erichkeane added a comment. The change itself doesn't really bother me at all, however the test will fail if we build without preserving names. In order to validate this you'll have to do fno-discard-value-names on a test. Comment at: clang/test/CodeGenOpenCL/address-spaces-

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added reviewers: erichkeane, rsmith. vzakhari added a comment. Adding more reviewers. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari created this revision. vzakhari added a reviewer: rjmccall. Herald added subscribers: cfe-commits, jfb, jvesely. Herald added a project: clang. Attach ".ascast" suffix to a value name when generating addrspacecast for it. This improves IR readability, e.g. for alloca variables, since al