[PATCH] D63786: Print NULL as "(null)" in diagnostic message

2019-06-26 Thread Xing Xue via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364462: Print NULL as "(null)" in diagnostic message (authored by xingxue, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D63786: Print NULL as "(null)" in diagnostic message

2019-06-25 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM. I have some minor style comments that could be fixed as part of the commit. Comment at: clang/tools/c-index-test/c-index-test.c:4648

[PATCH] D63786: Print NULL as "(null)" in diagnostic message

2019-06-25 Thread Andus Yu via Phabricator via cfe-commits
andusy created this revision. andusy added reviewers: hubert.reinterpretcast, xingxue, jasonliu, daltenty, cebowleratibm. andusy added a project: clang. Herald added subscribers: jsji, arphaman. Passing a null pointer to the `printf` family for a %s format specifier leads to undefined behaviour.