[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

2019-07-08 Thread Rainer Orth via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365396: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

2019-07-08 Thread Rainer Orth via Phabricator via cfe-commits
ro added a comment. In D63602#1574337 , @vitalybuka wrote: > In D63602#1570884 , @ro wrote: > > > Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has > > remained unreviewed for two weeks. > >

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

2019-07-08 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. In D63602#1570884 , @ro wrote: > Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has > remained unreviewed for two weeks.

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

2019-07-04 Thread Rainer Orth via Phabricator via cfe-commits
ro added a comment. Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has remained unreviewed for two weeks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63602/new/ https://reviews.llvm.org/D63602 _

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

2019-06-27 Thread Rainer Orth via Phabricator via cfe-commits
ro added a comment. Ping? It's been a week and I've since been informed that without it Solaris/SPARC compilation is broken since the `sancov_*` archives don't exit (compiler-rt isn't built on sparc). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63602/new/ htt

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

2019-06-20 Thread Rainer Orth via Phabricator via cfe-commits
ro created this revision. ro added a reviewer: alekseyshl. Herald added a subscriber: fedor.sergeev. Herald added a project: clang. As explained in https://reviews.llvm.org/D63601, there's no point using `clang_rt.sancov_{begin,end}` on Solaris any longer. This companion patch to the above remov