[PATCH] D63425: [clangd] Perform merge for main file symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363568: [clangd] Perform merge for main file symbols. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D63425: [clangd] Perform merge for main file symbols.

hokein added a comment. In D63425#1546010 , @kadircet wrote: > We also make use of `PickOne` in `updatePreamble` shouldn't that also cause > similar troubles? Yeah, we have similar problems in `updatePreamble`, but this is a correctness/performance tra

[PATCH] D63425: [clangd] Perform merge for main file symbols.

kadircet added a comment. We also make use of `PickOne` in `updatePreamble` shouldn't that also cause similar troubles? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63425/new/ https://reviews.llvm.org/D63425 ___

[PATCH] D63425: [clangd] Perform merge for main file symbols.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously, we randomly pick one main file symbol in dynamic index, we may loose the ideal symbol (with definition location) in the i