Re: [PATCH] D63194: [clangd] Link and initialize target infos

Hi Kadir, Thank you for looking into this. Unfortunately, I can't repro this anymore. I wonder if I had a weird stale clangd or something. Current test (now changed to armv7) does set the target properly. When I tried last time, it wasn't setting it, and was defaulting to my system's (darwin). Th

Re: [PATCH] D63194: [clangd] Link and initialize target infos

Hi Filipe! Thanks for letting me know, I've sent https://reviews.llvm.org/D77944 to enable this in clangd lit config. Regarding the failure, I can't seem to repro on machines I have access to. The premerge-tests also seems to be succeeding, please see https://results.llvm-merge-guard.org/BETA_amd6

Re: [PATCH] D63194: [clangd] Link and initialize target infos

Hi Kadir, Can you fix the target_info.test clangd test you committed in this revision, please? I see you've tried fixing it later by adding `REQUIRES: x86-registered-target`, but now it's never running because that feature isn't (ever) set. Here's a buildbot run showing it as unsupported (x86 targ

[PATCH] D63194: [clangd] Link and initialize target infos

kadircet closed this revision. kadircet added a comment. Landed as rL364387 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D63194

[PATCH] D63194: [clangd] Link and initialize target infos

kadircet updated this revision to Diff 206598. kadircet marked an inline comment as done. kadircet added a comment. - revert leftover change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D63194 Files: clang-to

[PATCH] D63194: [clangd] Link and initialize target infos

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:14 #include "clang/Tooling/CompilationDatabase.h" +#include "clang/Tooling/Tooling.h"