[PATCH] D63129: [clang-tidy] Fix invalid read on destruction

2019-06-11 Thread Nikolai Kosjar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363068: [clang-tidy] Fix invalid read on destruction (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTI

[PATCH] D63129: [clang-tidy] Fix invalid read on destruction

2019-06-11 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. This fix works. The alternative would have been to wrap these variables into llvm::ManagedStatic, just like the problematic TrueMatcherInstance in ASTMatchersInternal.cpp. Repository:

[PATCH] D63129: [clang-tidy] Fix invalid read on destruction

2019-06-11 Thread Nikolai Kosjar via Phabricator via cfe-commits
nik created this revision. Herald added subscribers: cfe-commits, jfb, xazax.hun. Herald added a project: clang. ...in case the clang tidy plugin is linked into the clang binary. Valgrind's memcheck reports: 8949== Invalid read ==8866== Invalid read of size 4