[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

rnk added a comment. In D63048#1605050 , @xbolva00 wrote: > Should we bump __GNUC__, __GNUC_MINOR__ too? We discussed this two weeks ago: http://lists.llvm.org/pipermail/cfe-dev/2019-July/062890.html It's unlikely that we will make any policy change befo

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

xbolva00 added a comment. https://bugs.llvm.org/show_bug.cgi?id=42817 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

xbolva00 added a comment. Some ICC behaviour.. icc -dumpversion 19.0.3.199 printf("%d %d %s", __GNUC__, __GNUC_MINOR__, __VERSION__); ./a.out 7 4 Intel(R) C++ gcc 7.4 mode Should we bump __GNUC__, __GNUC_MINOR__ too? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

This revision was automatically updated to reflect the committed changes. Closed by commit rL366091: Update __VERSION__ to remove the hardcoded 4.2.1 version (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANG

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 209715. sylvestre.ledru added a comment. Implement the change (just update __VERSION__) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/LanguageExtensions.rst

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. Actually, not sure it is a good idea to remove them: https://reviews.llvm.org/D64062#1566460 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

rnk added a comment. I'd be in favor of removing them. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. @rnk how do you feel about removing both? I can take care of that if you want Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

lebedev.ri added a comment. In D63048#1559894 , @lebedev.ri wrote: > In D63048#1559880 , @dexonsmith > wrote: > > > In D63048#1558806 , > > @sylvestre.ledru wrote: > > > >

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

lebedev.ri added a comment. In D63048#1559880 , @dexonsmith wrote: > In D63048#1558806 , @sylvestre.ledru > wrote: > > > @dexonsmith ping? > > > ... > FWIW, I feel similarly about `-dumpversion` (better to remo

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

dexonsmith added a comment. In D63048#1558806 , @sylvestre.ledru wrote: > @dexonsmith ping? I think I'd be a little more comfortable dropping `__VERSION__` entirely. There's already a way to access the clang version, and anyone with code that relies

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. @dexonsmith ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. I will wait for @dexonsmith 's opinion Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

rnk added a subscriber: dexonsmith. rnk added a comment. Personally, I think it's safe to do this. I believe this "4.2.1" compat thing was something Apple added as part of their switch from GCC, and then llvm-gcc, over to Clang, and I think most of the code they care about probably doesn't rely

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru marked an inline comment as done. sylvestre.ledru added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:610 + Builder.defineMacro("__VERSION__", "\"" CLANG_VERSION_STRING + " Compatible " + Twine(getClangFullCPPVersion()) + +

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

lebedev.ri added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:610 + Builder.defineMacro("__VERSION__", "\"" CLANG_VERSION_STRING + " Compatible " + Twine(getClangFullCPPVersion()) + + "\""); So how does

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 203700. sylvestre.ledru added a comment. fix rst syntax Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/ReleaseNotes.rst lib/Frontend/InitPreprocessor.cpp te

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

hubert.reinterpretcast added inline comments. Comment at: docs/ReleaseNotes.rst:79 - ``clang -dumpversion`` now returns the version of Clang itself. + Similarly, `__VERSION__` returns the Clang version instead of 4.2.1. I think this needs double backquotes on

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 203695. sylvestre.ledru added a comment. Fix the typo (thanks hubert) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/ReleaseNotes.rst lib/Frontend/InitPreproc

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

hubert.reinterpretcast added inline comments. Comment at: docs/ReleaseNotes.rst:79 - ``clang -dumpversion`` now returns the version of Clang itself. + Similarly, __VERSION__ returns the Clang version instead of 4.2.1. Use code font for `__VERSION__`. ==

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. In D63048#1535222 , @xbolva00 wrote: > Btw, what about this code > > // Currently claim to be compatible with GCC 4.2.1-5621, but only if we're > // not compiling for MSVC compatibility > Builder.defineMacro("__GNUC_M

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 203693. sylvestre.ledru added a comment. update of the release notes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/ReleaseNotes.rst lib/Frontend/InitPreproce

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

xbolva00 added a comment. Btw, what about this code // Currently claim to be compatible with GCC 4.2.1-5621, but only if we're // not compiling for MSVC compatibility Builder.defineMacro("__GNUC_MINOR__", "2"); Builder.defineMacro("__GNUC_PATCHLEVEL__", "1"); Builder.defineMacro("__GNUC

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: rnk. Herald added a subscriber: fedor.sergeev. Herald added a project: clang. Just like in https://reviews.llvm.org/D56803 for -dumpversion Repository: rC Clang https://reviews.llvm.org/D63048 Files: lib/Frontend/Init