[PATCH] D62493: [Driver] Always use Unix-style paths in the Darwin driver

ldionne added a comment. In D62493#1519708 , @rnk wrote: > So, there's nothing wrong, functionally speaking, with what we do today, > right? It's just inconvenient to test. What we do for Darwin today (without this patch) is functionally correct, but h

[PATCH] D62493: [Driver] Always use Unix-style paths in the Darwin driver

rnk added a comment. So, there's nothing wrong, functionally speaking, with what we do today, right? It's just inconvenient to test. The difficulty of testing the driver has been a long standing problem. I think we might want to instead invent some new kind of alternative to `-###` for writing

[PATCH] D62493: [Driver] Always use Unix-style paths in the Darwin driver

dexonsmith added a comment. This doesn’t look okay to me, because this would prevent building for Darwin when running on Windows. I added a couple of reviewers that have Windows experience and might have ideas for how to fix the tests without breaking the portability of the driver. Repositor

[PATCH] D62493: [Driver] Always use Unix-style paths in the Darwin driver

ldionne added a comment. A few notes: - I did setup a Windows machine and run the tests on it - I'd welcome a better way to solve this problem than ripping out the use of `llvm::sys::path::append`, but I wasn't able to find anything in `FileCheck` that would do it Repository: rG LLVM Github

[PATCH] D62493: [Driver] Always use Unix-style paths in the Darwin driver

ldionne created this revision. ldionne added reviewers: jfb, rsmith. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Otherwise, the unit tests seem to be confused on Windows. Note that it would in theory be better to always use the platform's path, howeve