This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL363712: [clang-tidy] Split fuchsia-default-arguments
(authored by juliehockett, committed by ).
Herald added a project: LL
DiegoAstiazaran updated this revision to Diff 204157.
DiegoAstiazaran added a comment.
Improve format of documentation in ReleaseNotes.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62437/new/
https://reviews.llvm.org/D62437
Files:
clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:122
+ Warns if a function or method is called with default arguments.
+ This was previously done by fuchsia-default-arguments check, which has been
+ removed.
Please high
DiegoAstiazaran updated this revision to Diff 203447.
DiegoAstiazaran added a comment.
Complete documentation in ReleaseNotes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62437/new/
https://reviews.llvm.org/D62437
Files:
clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt
clang-to
juliehockett added a comment.
Sorry for the delay!
Comment at:
clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsCallsCheck.cpp:24
+ const auto *S = Result.Nodes.getNodeAs("stmt");
+ if (S == nullptr)
+return;
Just `if (!S)` should be sufficient here.
hokein added a comment.
@juliehockett could you take a look on this patch? I think you have the best
knowledge about this check and fuchsia stuff.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62437/new/
https://reviews.llvm.org/D62437
___
DiegoAstiazaran updated this revision to Diff 201799.
DiegoAstiazaran added a comment.
Fix patch submitted.
Patch submitted with the last update was a new commit, functional changes were
not included in that diff.
New patch includes functional changes (first patch) and format changes (second
pat
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
It seems that the functional changes are missing from the patch -- all I see
are formatting changes; have I missed something?
Comment at:
clang-tool
DiegoAstiazaran updated this revision to Diff 201375.
DiegoAstiazaran added a comment.
Reduces lines to 80 characters. The files have been also formatted by
clang-format.
Types are replaced by auto in declarations where the type is spelled in cast.
CHANGES SINCE LAST ACTION
https://reviews.ll
Eugene.Zelenko added inline comments.
Comment at:
clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsCallsCheck.cpp:1
+//===--- DefaultArgumentsCallsCheck.cpp -
clang-tidy---===//
+//
Please add space after clang-tidy.
C
Eugene.Zelenko added a comment.
Please mention renaming of existing check in Release Notes (after list of new
checks).
Comment at:
clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsDeclarationsCheck.cpp:23
+void DefaultArgumentsDeclarationsCheck::check(const MatchFinder::M
DiegoAstiazaran created this revision.
DiegoAstiazaran added a reviewer: juliehockett.
DiegoAstiazaran added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Splits fuchsia-default-arguments check into two checks.
fuchsia-default-arguments-calls warns if a function or me
12 matches
Mail list logo
