v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Herald added subscribers: wuzish, MaskRay.
r365153.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62293/new/
https://reviews.llvm.org/D62293
___
cfe-co
v.g.vassilev updated this revision to Diff 206887.
v.g.vassilev marked an inline comment as done.
v.g.vassilev added a comment.
Add comments, add missing callbacks. Thanks Richard!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62293/new/
https://reviews.llvm.org/
rsmith added a comment.
`PPCallbacks` seems to be missing the addition of `EnteredSubmodule` and
`LeftSubmodule`; `PPChainedCallbacks` seems to be missing the addition of
`LeftSubmodule`.
Generally this seems reasonable.
Comment at: lib/Lex/PPLexerChange.cpp:783
+if (Cal
v.g.vassilev created this revision.
v.g.vassilev added reviewers: rsmith, bruno.
Herald added subscribers: jsji, dexonsmith, kbarton, nemanjai.
Herald added a project: clang.
Our usecase is that we would like to support making some modules visible
(without corresponding #includes) while building
