This revision was automatically updated to reflect the committed changes.
Closed by commit rC361757: [OpenCL] Fix file-scope const sampler variable for
2.0 (authored by yaxunl, committed by ).
Herald added a project: clang.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
Makes sense. LGTM! Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62197/new/
https://reviews.llvm.org/D62197
___
cfe-commit
yaxunl updated this revision to Diff 200509.
yaxunl added a comment.
Add full diff.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62197/new/
https://reviews.llvm.org/D62197
Files:
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/sampler.cl
test/SemaOpenCL/sampler_t.cl
Index: test/SemaOp
yaxunl created this revision.
yaxunl added a reviewer: Anastasia.
OpenCL spec v2.0 s6.13.14:
Samplers can also be declared as global constants in the program
source using the following syntax.
const sampler_t =
This works fine for OpenCL 1.2 but fails for 2.0, because clang duduces
