This revision was automatically updated to reflect the committed changes.
Closed by commit rL362038: CodeView - add static data members to global
variable debug info. (authored by akhuang, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D62167?vs=202027&id=202063#toc
Reposito
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62167/new/
https://reviews.llvm.org/D62167
___
cfe-
akhuang updated this revision to Diff 202027.
akhuang added a comment.
Herald added a subscriber: hiraditya.
Append class name to static data member debug info name.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62167/new/
https://reviews.llvm.org/
dblaikie added a comment.
Is this the change we were discussing the other week semi-related to preserved
enums? It sounded to me like the conclusion was somewhat to go ahead without
adding all these things to the constant list and see how it goes? Is this case
different from the enum case in so
rnk added subscribers: manmanren, probinson.
rnk added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385
+// Use the global scope for static members.
+DContext = getContextDescriptor(
+ cast(CGM.getContext().getTranslationUnitDecl()), TheCU);
-
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385
+// Use the global scope for static members.
+DContext = getContextDescriptor(
+ cast(CGM.getContext().getTranslationUnitDecl()), TheCU);
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385
+// Use the global scope for static members.
+DContext = getContextDescriptor(
+ cast(CGM.getContext().getTranslationUnitDecl()), TheCU);
akhuang updated this revision to Diff 201004.
akhuang added a comment.
Add llvm IR test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62167/new/
https://reviews.llvm.org/D62167
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGenCXX/de
dblaikie added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385
+// Use the global scope for static members.
+DContext = getContextDescriptor(
+ cast(CGM.getContext().getTranslationUnitDecl()), TheCU);
akhuang wrote:
> @dblaikie I
akhuang marked an inline comment as done.
akhuang added a subscriber: dblaikie.
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385
+// Use the global scope for static members.
+DContext = getContextDescriptor(
+ cast(CGM.getContext().g
rnk added a comment.
This needs a clang-side test to show that clang generates the expected IR for
static data members.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62167/new/
https://reviews.llvm.org/D62167
___
akhuang created this revision.
akhuang added a reviewer: rnk.
Herald added subscribers: llvm-commits, cfe-commits, aprantl.
Herald added projects: clang, LLVM.
Add static data members to IR debug info's list of global variables
so that they are emitted as S_CONSTANT records.
Related to https://bu
12 matches
Mail list logo
