[PATCH] D62156: [Sema] Diagnose addr space mismatch while constructing objects

2019-05-23 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 201011. Anastasia added a comment. - Switched back to loop over all method qualifiers - Moved addr space check into `AddOverloadCandidate` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62156/new/ https://reviews.llvm.org/D62156 Files: include/c

[PATCH] D62156: [Sema] Diagnose addr space mismatch while constructing objects

2019-05-20 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:8229 + if (FTI.hasMethodTypeCVRUQualifiers()) { +FTI.MethodQualifiers->forEachCVRUQualifier( [&](DeclSpec::TQ TypeQual, StringRef QualName, SourceLocation SL) { We want to catch `_

[PATCH] D62156: [Sema] Diagnose addr space mismatch while constructing objects

2019-05-20 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: ebevhan. Anastasia edited the summary of this revision. Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:3771 else

[PATCH] D62156: [Sema] Diagnose addr space mismatch while constructing objects

2019-05-20 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:3771 else { - // C++ [over.match.copy]p1: - // - When initializing a temporary to be bound to the first parameter - // of a constructor [for ty