[PATCH] D62125: Run ClangTidy tests in all C++ language modes

2019-05-20 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr added a comment. > c++98 coverage is a rather niche thing there days. I believe, someone with > genuine need for C++98 support can work on that. +1, that's exactly the reason why I skipped 98. C++98 is 21 years old now (or 16 if you count from C++03). Most projects that build with a

[PATCH] D62125: Run ClangTidy tests in all C++ language modes

2019-05-20 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. That's a quite impressive amount of work. Thanks! Looks good. In D62125#1508113 , @JonasToth wrote: > Wow, a lot of work! > > I did not check all test

[PATCH] D62125: Run ClangTidy tests in all C++ language modes

2019-05-20 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. Wow, a lot of work! I did not check all test files, but I saw that you explicitly enabled c++11,14,17 but not 98. Is there a reason for that? I think we should test that standard too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D62125: Run ClangTidy tests in all C++ language modes

2019-05-20 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. gribozavr added a reviewer: alexfh. Herald added subscribers: cfe-commits, lebedev.ri, jdoerfert, arphaman, kbarton, nemanjai. Herald added a reviewer: lebedev.ri. Herald added a project: clang. I inspected every test and did one of the following: - changed the t