This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG265ed6819409: [clang-format] Fix a JavaScript import order
bug (authored by owenpan).
Changed prior to commit:
https://reviews.llvm.org/D61663?vs=
owenpan updated this revision to Diff 557879.
owenpan added a comment.
Make the test case pass.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61663/new/
https://reviews.llvm.org/D61663
Files:
clang/lib/Format/SortJavaScriptImports.cpp
clang/unittests/Format/SortImportsTestJS.cpp
owenpan commandeered this revision.
owenpan edited reviewers, added: bowenni; removed: owenpan.
owenpan added a comment.
The test case doesn't pass.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61663/new/
https://reviews.llvm.org/D61663
shafik added a comment.
Herald added a project: All.
Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay.
@MyDeveloperDay this looks like it still could be relevant.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61663/new/
https://reviews.
MyDeveloperDay added a comment.
Are you waiting for someone to land this?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61663/new/
https://reviews.llvm.org/D61663
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Generally, upload patches with the full file as context (that will prevent
Phabricator's "Context not available")
But this change looks good. Thank you.
Repository:
rC Clang
CHANGES SINC
bowenni created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
bowenni retitled this revision from "Fix a JavaScript import order bug." to
"[clang-format] Fix a JavaScript import order bug.".
When the imported symbol is exactly "template" the sorting is disa
