jdenny marked an inline comment as done.
jdenny added inline comments.
Comment at: clang/docs/ClangPlugins.rst:58
ExamplePragmaHandler() : PragmaHandler("example_pragma") { }
-void HandlePragma(Preprocessor &PP, PragmaIntroducerKind Introducer,
+void HandlePragma(Pre
lebedev.ri accepted this revision.
lebedev.ri added a comment.
No one raised any concerns, so let's do **this**.
Comment at: clang/docs/ClangPlugins.rst:58
ExamplePragmaHandler() : PragmaHandler("example_pragma") { }
-void HandlePragma(Preprocessor &PP, PragmaIntroduce
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang/docs/ClangPlugins.rst:58
ExamplePragmaHandler() : PragmaHandler("example_pragma") { }
-void HandlePragma(Preprocessor &PP, Prag
jdenny marked an inline comment as done.
jdenny added inline comments.
Comment at: clang/docs/ClangPlugins.rst:58
ExamplePragmaHandler() : PragmaHandler("example_pragma") { }
-void HandlePragma(Preprocessor &PP, PragmaIntroducerKind Introducer,
+void HandlePragma(Pre
jdenny marked an inline comment as done.
jdenny added inline comments.
Comment at: clang/docs/ClangPlugins.rst:58
ExamplePragmaHandler() : PragmaHandler("example_pragma") { }
-void HandlePragma(Preprocessor &PP, PragmaIntroducerKind Introducer,
+void HandlePragma(Pre
lebedev.ri added inline comments.
Comment at: clang/docs/ClangPlugins.rst:58
ExamplePragmaHandler() : PragmaHandler("example_pragma") { }
-void HandlePragma(Preprocessor &PP, PragmaIntroducerKind Introducer,
+void HandlePragma(Preprocessor &PP, PragmaIntroducer Intro
jdenny marked an inline comment as done.
jdenny added inline comments.
Comment at: clang/docs/ClangPlugins.rst:58
ExamplePragmaHandler() : PragmaHandler("example_pragma") { }
-void HandlePragma(Preprocessor &PP, PragmaIntroducerKind Introducer,
+void HandlePragma(Pre
lebedev.ri added reviewers: rsmith, aaron.ballman.
lebedev.ri added a comment.
Seems like obvious NFC to me, but i'm not sure about API/ABI implications for
external use.
Comment at: clang/docs/ClangPlugins.rst:58
ExamplePragmaHandler() : PragmaHandler("example_pragma") {
jdenny created this revision.
jdenny added reviewers: ABataev, lebedev.ri.
Herald added a subscriber: jdoerfert.
Herald added a project: clang.
Currently, a pragma AST node's recorded location starts at the
namespace token (such as `omp` in the case of OpenMP) after the
`#pragma` token, and the
