[PATCH] D61496: Fixed tests where grep was not matching the linefeed

This revision was automatically updated to reflect the committed changes. Closed by commit rC360467: Fixed tests where grep was not matching the linefeed (authored by aganea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61496?vs=197990&id=199069#toc Repository: rC Clang

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/trunk/test/Preprocessor/indent_macro.c:1-2 -// RUN: %clang_cc1 -E %s | grep '^ zzap$' +// RUN: %clang_cc1 -E %s | FileCheck %s --match-full-lines --strict-whitespace +// CHECK: zzap ---

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Sure, this looks better. Comment at: clang/trunk/test/Preprocessor/indent_macro.c:1-2 -// RUN: %clang_cc1 -E %s | grep '^ zzap$' +// RUN: %clang_cc1 -E %s | FileChe

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

aganea added a comment. In D61496#1489523 , @probinson wrote: > Checked-in files should not have CRLF endings, in general (there are a very > few exceptions, and these aren't among them). > If the checked-in files have LF endings but your tool checks the

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

aganea updated this revision to Diff 197990. aganea added a comment. Changed to use `FileCheck` instead of `grep` Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61496/new/ https://reviews.llvm.org/D61496 Files: clang/trunk/test/Preprocessor/indent_macro.c cla

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

probinson added a comment. Checked-in files should not have CRLF endings, in general (there are a very few exceptions, and these aren't among them). If the checked-in files have LF endings but your tool checks them out with CRLF then that is a problem with your config, or with the tool. Adding d

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. The tests should be fixed to use `FileCheck`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61496/new/ https://reviews.llvm.org/D61496 ___

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

aganea created this revision. aganea added reviewers: rnk, jlebar. aganea added a project: clang. Herald added a subscriber: mstorsjo. aganea edited the summary of this revision. The files below have been synced by Tortoise as CRLF, and it looks like they are like that in the depot as well (I'm s