This revision was automatically updated to reflect the committed changes.
Closed by commit rC359530: [analyzer] SmartPtrModeling: Fix a null dereference.
(authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61285?vs=197222&id=197251#toc
Repository:
rC Cl
NoQ added a comment.
The whole AST consists in passing raw unannotated pointers around and i suspect
it'll be annoying to deal with `Stmt &`s and `Decl &`s specifically in the
Analyzer when all AST APIs accept pointers.
I guess we'll have to go with some sort of nullability annotations, yeah. B
xazax.hun accepted this revision.
xazax.hun added a comment.
LG! These mistakes are so easy to make. Maybe we should add nullability
annotations (or use optionals) in the future? (Or just make every non-null
pointer a reference and make it a convention to always check for nulls?)
Repository:
Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.
When I see `->*` I go mad, but we should handle unknown stuff, cool patch.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61285/new/
https://reviews.llvm.or
