This revision was automatically updated to reflect the committed changes.
Closed by commit rL359285: [MinGW] Fix dllexport of explicit template
instantiation (authored by mstorsjo, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ht
mstorsjo updated this revision to Diff 196704.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.
Adjusted the patch to not warn if there is no previous declaration of the
instantiation, allowing the dllexport attribute on the definition in that case.
CHANGES SINCE LAST ACT
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61118/new/
https://reviews.llvm.org/D61118
___
cfe-c
smeenai added a comment.
LGTM, though I'd wait for Hans and/or Reid too.
I like the GCC/MinGW behavior here much more than the MSVC behavior. Having to
mark the definitions only in the explicit instantiations case (for MSVC)
whereas everything else requires you to mark the declarations is a wei
mstorsjo created this revision.
mstorsjo added reviewers: rnk, hans, smeenai.
Herald added a project: clang.
Contrary to MSVC, GCC/MinGW needs to have the dllexport attribute on the
template instantiation declaration, not on the definition.
Previously clang never marked explicit template instant
