[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

2019-04-22 Thread Joel E. Denny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC358917: [VerifyDiagnosticConsumer] Document -verify= in doxygen (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D60845?vs=195742&id=196127#toc Repositor

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

2019-04-18 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In D60845#1472291 , @rsmith wrote: > In D60845#1471741 , @jdenny wrote: > > > In D60845#1471002 , @rsmith wrote: > > > > > I've seen a few projects ou

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

2019-04-18 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D60845#1471741 , @jdenny wrote: > In D60845#1471002 , @rsmith wrote: > > > I've seen a few projects outside of clang use `-verify` mode for their own > > testing of various things. > > >

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

2019-04-18 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. Thanks for the accepts. In D60845#1470986 , @NoQ wrote: > In D60845#1470980 , @Charusso wrote: > > > I really like live working examples, I hope not just me. Could you link > > https://gith

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

2019-04-18 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny updated this revision to Diff 195742. jdenny added a comment. Clarify the behavior of multiple -verify options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60845/new/ https://reviews.llvm.org/D60845 Files: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h Index: clan

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

2019-04-17 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D60845#1470986 , @NoQ wrote: > Yup, i confirm that this improves discoverability of this feature :) Maybe it > deserves its own .rst doc, like FileCheck > , but for now doxygen

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

2019-04-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Yup, i confirm that this improves discoverability of this feature :) Maybe it deserves its own .rst doc, like FileCheck , but for now doxygen seems to be the best source of truth on how to use -verify and i consult it regul

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

2019-04-17 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Thanks you! I really like live working examples, I hope not just me. Could you link https://github.com/llvm/llvm-project/blob/master/clang/test/Analysis/use-after-move.cpp as well as a li

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

2019-04-17 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny created this revision. jdenny added reviewers: NoQ, Charusso, hfinkel, rsmith. Herald added a project: clang. Previously, it was only documented by `-cc1 -help`, so people weren't aware of it, as discussed in D60732 . Repository: rG LLVM Github Monorepo