[PATCH] D60827: [rename] Deduplicate symbol occurrences

kadircet requested changes to this revision. kadircet added a comment. This revision now requires changes to proceed. Note that the bug has been fixed with D61596 incidentally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D60827: [rename] Deduplicate symbol occurrences

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/unittests/clangd/ClangdTests.cpp:1160 +TEST_F(ClangdVFSTest, NoDuplicatedTextEditsOnRename) { + MockFSProvider FS; kadircet wrote: > maybe put the test under c

[PATCH] D60827: [rename] Deduplicate symbol occurrences

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks Comment at: clang-tools-extra/unittests/clangd/ClangdTests.cpp:1160 +TEST_F(ClangdVFSTest, NoDuplicatedTextEditsOnRename) { + MockFSProvider FS; ---

[PATCH] D60827: [rename] Deduplicate symbol occurrences

hokein created this revision. hokein added reviewers: arphaman, kadircet. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. SymbolOccurrences is not guaranteed to be unique -- as some parts of the AST may get traversed twice, we may add duplicated occurrences, we should