This revision was automatically updated to reflect the committed changes.
Closed by commit rL358783: [MS] Emit S_HEAPALLOCSITE debug info (authored by
akhuang, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D60800?vs=195877&id=195909#toc
Repository:
rL LLVM
CHANGES SINCE
akhuang updated this revision to Diff 195877.
akhuang added a comment.
whitespace fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
llvm/include/llvm/CodeGen/M
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm with a minor whitespace issue
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1972
}
-
CI->setMetadata("heapallocsite", node);
Please revert the white spa
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: llvm/test/CodeGen/X86/label-heapallocsite.ll:1
+; RUN: llc -O0 < %s | FileCheck %s
+; FIXME: Add test for llc with optimizations once it is implemented.
hans wrote:
> Does llc ha
akhuang updated this revision to Diff 195821.
akhuang marked 2 inline comments as done.
akhuang added a comment.
- Changed test case back to original
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
akhuang updated this revision to Diff 195818.
akhuang marked 2 inline comments as done.
akhuang added a comment.
- Pass void metadata as null DIType
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
rnk added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1966
+ QualType PointeeTy = D.getTypePtr()->getPointeeType();
+ llvm::DIType *DI = getOrCreateType(PointeeTy, getOrCreateFile(Loc));
+ CI->setMetadata("heapallocsite", DI);
akhuang wrote:
akhuang added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1966
+ QualType PointeeTy = D.getTypePtr()->getPointeeType();
+ llvm::DIType *DI = getOrCreateType(PointeeTy, getOrCreateFile(Loc));
+ CI->setMetadata("heapallocsite", DI);
hans wrote
akhuang updated this revision to Diff 195783.
akhuang marked 4 inline comments as done.
akhuang added a comment.
Removed extraneous information from test; changed type to DIType
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://revie
hans added a comment.
I don't really know about the functionality here, just adding a few comments on
the code itself.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1966
+ QualType PointeeTy = D.getTypePtr()->getPointeeType();
+ llvm::DIType *DI = getOrCreateType(PointeeTy,
akhuang updated this revision to Diff 195480.
akhuang added a comment.
Fix test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGen/debug-inf
akhuang updated this revision to Diff 195478.
akhuang added a comment.
more typos
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGen/debug-info-c
akhuang updated this revision to Diff 195475.
akhuang added a comment.
remove comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60800/new/
https://reviews.llvm.org/D60800
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGen/debug-in
akhuang created this revision.
akhuang added reviewers: hans, rnk.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, aprantl.
Herald added projects: clang, LLVM.
This emits labels around heapallocsite calls and S_HEAPALLOCSITE debug
info in codeview. Currently only changes FastISel,
14 matches
Mail list logo
