[PATCH] D60776: [clang-tidy] Add test support for the fix description.

2019-05-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Based on our last offline discussion, it is possible to use `CHECK-NOTES` to verify fix descriptions. However, `CHECK-NOTES` enforce sto verify all `note` diagnostic messages, some existing tests will be failed because they don't cover all notes (the number is not large,

[PATCH] D60776: [clang-tidy] Add test support for the fix description.

2019-05-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 201221. hokein added a comment. Use CHECK-NOTES. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60776/new/ https://reviews.llvm.org/D60776 Files: clang-tools-extra/test/clang-tidy/misc-unused-using-decls.cpp

[PATCH] D60776: [clang-tidy] Add test support for the fix description.

2019-04-16 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:109 check_notes_prefix = 'CHECK-NOTES' + file_check_suffix +check_fix_descriptions_pr

[PATCH] D60776: [clang-tidy] Add test support for the fix description.

2019-04-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 195385. hokein added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60776/new/ https://reviews.llvm.org/D60776 Files: clang-tools-extra/test/clang-tidy/check_clang_tidy.py clang-tools-extr

[PATCH] D60776: [clang-tidy] Add test support for the fix description.

2019-04-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: alexfh. Herald added a subscriber: xazax.hun. Herald added a project: clang. Add a new annotation "CHECK-FIX-DESCRIPTIONS" to lit test to verify the fix description provided by checks. Repository: rG LLVM Github Monorepo https://reviews.l