[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

simon_tatham marked 3 inline comments as done. simon_tatham added inline comments. Comment at: cfe/trunk/lib/Basic/Targets/ARM.cpp:912 + return true; +} case 'U': // a memory reference... craig.topper wrote: > Is this supposed to fallthrough from 'T'

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

craig.topper added inline comments. Comment at: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp:14098 } + + case 2: Is this supposed to fallthrough from case 1 to case 2? Comment at: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp:14113 +

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

craig.topper added inline comments. Comment at: cfe/trunk/lib/Basic/Targets/ARM.cpp:912 + return true; +} case 'U': // a memory reference... Is this supposed to fallthrough from 'T' to 'U'? If so can you add an LLVM_FALLTHROUGH Repository: rL LLV

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364331: [ARM] Support inline assembler constraints for MVE. (authored by statham, committed by ). Changed prior to commit: https://reviews.llvm.org/D60709?vs=206455&id=206472#toc Repository: rL LLVM

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

simon_tatham updated this revision to Diff 206455. simon_tatham added a comment. Rebased this patch to current trunk, and also fixed a test failure by adding `arm_aapcs_vfpcc` to the test functions that use MVE vector types (since we can't support passing vector types in GPRs until we get all th

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

simon_tatham updated this revision to Diff 204039. simon_tatham added a comment. Remastered patch to apply cleanly against current trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60709/new/ https://reviews.llvm.org/D60709 Files: clang/lib/B

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Excellent, looks good to me then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60709/new/ https://reviews.llvm.org/D60709

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

simon_tatham added a comment. Yes, it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60709/new/ https://reviews.llvm.org/D60709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

t.p.northover added a comment. Is this coordinated with GCC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60709/new/ https://reviews.llvm.org/D60709 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, samparker, SjoerdMeijer. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, eraman, javed.absar. Herald added projects: clang, LLVM. "To" selects an odd-numbered GPR, and "Te" an even one. There