[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. yeah thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60379/new/ https://reviews.llvm.org/D60379 ___ cfe-commits mailing list cfe-commits@

[PATCH] D60379: Make precompiled headers reproducible

Anastasia added a comment. Can this be closed now due to commit r358674? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60379/new/ https://reviews.llvm.org/D60379 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D60379: Make precompiled headers reproducible

Anastasia added a comment. FYI, I switched to `std::map` in this review: https://reviews.llvm.org/D60778 @sylvestre.ledru do you think it's possible to apply this patch and see if it work for your bug? Btw I am still confused about the reproducibility - does clang produce the same PCH at leas

[PATCH] D60379: Make precompiled headers reproducible

Anastasia added inline comments. Comment at: lib/Serialization/ASTWriter.cpp:4283 + // Sort to allow reproducible .pch files - https://bugs.debian.org/877359 + std::map> sortedOpenCLTypeExtMap; for (const auto &I : SemaRef.OpenCLTypeExtMap) { riccibruno wrot

[PATCH] D60379: Make precompiled headers reproducible

riccibruno added a comment. In D60379#1458799 , @thakis wrote: > In D60379#1458668 , @riccibruno > wrote: > > > After looking at the bug report (https://bugs.debian.org/877359), I would > > like to point out that

[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru added a comment. To be clear, this isn't about format stability and distributing but making sure that two same runs of clang produces the same output. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60379/new/ https://reviews.llvm.org/D60379 ___

[PATCH] D60379: Make precompiled headers reproducible

thakis added a comment. In D60379#1458668 , @riccibruno wrote: > After looking at the bug report (https://bugs.debian.org/877359), I would > like to point out that there is currently *absolutely* no stability guarantee > for the serialization format (ie,

[PATCH] D60379: Make precompiled headers reproducible

riccibruno added a comment. After looking at the bug report (https://bugs.debian.org/877359), I would like to point out that there is currently *absolutely* no stability guarantee for the serialization format (ie, you need the exact same revision). In regard of this I am wondering how sane it i

[PATCH] D60379: Make precompiled headers reproducible

riccibruno added inline comments. Comment at: lib/Serialization/ASTWriter.cpp:4283 + // Sort to allow reproducible .pch files - https://bugs.debian.org/877359 + std::map> sortedOpenCLTypeExtMap; for (const auto &I : SemaRef.OpenCLTypeExtMap) { lebedev.ri wro

[PATCH] D60379: Make precompiled headers reproducible

lebedev.ri added inline comments. Comment at: lib/Serialization/ASTWriter.cpp:4283 + // Sort to allow reproducible .pch files - https://bugs.debian.org/877359 + std::map> sortedOpenCLTypeExtMap; for (const auto &I : SemaRef.OpenCLTypeExtMap) { Anastasia wrot

[PATCH] D60379: Make precompiled headers reproducible

Anastasia added inline comments. Comment at: lib/Serialization/ASTWriter.cpp:4283 + // Sort to allow reproducible .pch files - https://bugs.debian.org/877359 + std::map> sortedOpenCLTypeExtMap; for (const auto &I : SemaRef.OpenCLTypeExtMap) { lebedev.ri wrot

[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru added a comment. I won't have time to write the test for that (and would not know where to start). I am just the messenger :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60379/new/ https://reviews.llvm.org/D60379

[PATCH] D60379: Make precompiled headers reproducible

lebedev.ri added a comment. Needs a test. Comment at: lib/Serialization/ASTWriter.cpp:4283 + // Sort to allow reproducible .pch files - https://bugs.debian.org/877359 + std::map> sortedOpenCLTypeExtMap; for (const auto &I : SemaRef.OpenCLTypeExtMap) { Woul

[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: yaxunl, Anastasia. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch have been applied to Debian packages for a few months without any regression. Patch by Rebecca N. Palmer Repository: rC