[PATCH] D60308: Leave alone the semicolon after the MacroBlockBegin name

2019-04-05 Thread Owen Pan via Phabricator via cfe-commits
owenpan abandoned this revision. owenpan added a comment. The semicolon is redundant but makes the MacroBlockBegin name stand out more. Nonetheless, I agree it's not a bug and we should leave the current behavior as is. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D60308: Leave alone the semicolon after the MacroBlockBegin name

2019-04-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. The documentation examples of MacroBlockBegin are: /// A regular expression matching macros that start a block. /// \code ///# With: ///MacroBlockBegin: "^NS_MAP_BEGIN|\ ///NS_TABLE_HEAD$" ///MacroBlockEnd: "^\ ///NS_MAP_END|\ ///

[PATCH] D60308: Leave alone the semicolon after the MacroBlockBegin name

2019-04-04 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: sammccall, klimek, djasper, krasimir. owenpan added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes the bug below. The code: FOO_BEGIN(); FOO_ENTRY FOO_END(); is erroneously formatted to: FOO_BEGIN()