This revision was automatically updated to reflect the committed changes.
Closed by commit rL357173: [clangd] Support UTF-32 (i.e. codepoint) offsets.
(authored by sammccall, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINC
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: unittests/clangd/SourceCodeTests.cpp:164
+ llvm::Failed()); // out of range
+ // middle line
+ EXPECT_THAT_EXPECTED(positionToOffset(File, position(1, -1)),
--
sammccall updated this revision to Diff 192628.
sammccall added a comment.
Fix capitalization.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59927/new/
https://reviews.llvm.org/D59927
Files:
clangd/Protocol.cpp
clangd/Protocol.h
clangd/Source
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: unittests/clangd/SourceCodeTests.cpp:164
+ llvm::Failed()); // out of range
+ // middle line
+ EXPECT_THAT_EXPECTED(pos
ilya-biryukov added a reviewer: gribozavr.
ilya-biryukov added a subscriber: gribozavr.
ilya-biryukov added a comment.
NIT: maybe remove parentheses from the change description, they seem to only
add noise.
Adding @gribozavr who definitely knows more about Unicode :-)
Repository:
rCTE Clang T
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
Herald added a project: clang.
(Changes to UTF-8/UTF-16 here are NFC, moving things around to make the
cases more symmetrical)
Reposit
