rnk added a comment.
I think I've addressed all the comments, and I know that @ruiu is currently
travelling or recovering from travel to Japan, so I'll go ahead and land this.
Feel free to provide post-commit feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
rnk added a comment.
I added one last size optimization, replacing a std::vector with a forward
linked list and a custom iterator for it. PTAL
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59797/new/
https://reviews.llvm.org/D59797
rnk updated this revision to Diff 192752.
rnk added a comment.
- Replace std::vector<> with singly linked list
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59797/new/
https://reviews.llvm.org/D59797
Files:
lld/COFF/Chunks.cpp
lld/COFF/Chunks.
smeenai added inline comments.
Comment at: lld/COFF/Chunks.cpp:47
+namespace {
+// This class exists just for the purpose of calculating the expected size of
pcc wrote:
> rnk wrote:
> > ruiu wrote:
> > > rnk wrote:
> > > > ruiu wrote:
> > > > > rnk wrote:
> > >
pcc added inline comments.
Comment at: lld/COFF/Chunks.cpp:47
+namespace {
+// This class exists just for the purpose of calculating the expected size of
rnk wrote:
> ruiu wrote:
> > rnk wrote:
> > > ruiu wrote:
> > > > rnk wrote:
> > > > > ruiu wrote:
> > > >
rnk marked 4 inline comments as done.
rnk added inline comments.
Comment at: lld/COFF/Chunks.cpp:47
+namespace {
+// This class exists just for the purpose of calculating the expected size of
ruiu wrote:
> rnk wrote:
> > ruiu wrote:
> > > rnk wrote:
> > > > rui
rnk updated this revision to Diff 192223.
rnk added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
- replace struct with current size
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59797/new/
https://reviews.llvm.o
