[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356799: [NFC] ExceptionEscapeCheck: small refactoring (authored by lebedevri, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59650/new/ http

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri added a comment. I'm gonna go with post-commit review here, if @baloghadamsoftware will have any notes, although this now looks rather uncontroversial. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59650/new/ https://reviews.llvm.org/D59

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoilerplate(const T *Node) { + ExceptionInfo ExceptionList; griboza

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoilerplate(const T *Node) { + ExceptionInfo ExceptionList; lebedev.r

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri marked an inline comment as done. lebedev.ri added a comment. @gribozavr thank you for the review! @baloghadamsoftware any comments? Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoilerplate(const

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

gribozavr accepted this revision. gribozavr marked an inline comment as done. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoil

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoilerplate(const T *Node) { + ExceptionInfo ExceptionList; gribozavr wrote: > JonasToth wrote: > > lebedev.ri w

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri updated this revision to Diff 191868. lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. Address some nits. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59650/new/ https://reviews.llvm.org/D59650 Files: clang-tid

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

gribozavr added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:208 +template <> +void ExceptionAnalyzer::analyze(const FunctionDecl *Func, +ExceptionInfo &ExceptionList) { I'd suggest to make it a non-template

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

JonasToth added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoilerplate(const T *Node) { + ExceptionInfo ExceptionList; lebedev.ri wrote: > Please bikeshed on the name. I do

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoilerplate(const T *Node) { + ExceptionInfo ExceptionList; Please

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri updated this revision to Diff 191782. lebedev.ri added a comment. Keep templated function out of the public interface. In D59650#1438603 , @JonasToth wrote: > > Looks like pointless code duplication that is easily avoidable. > > True, but I wou

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

JonasToth added a comment. > Looks like pointless code duplication that is easily avoidable. True, but I would prefer the refactoring to be private then (so the template stuff with the boilerplate) and a simple overloading interface dispatching to the templated stuff. In the end I think the pub

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri added a comment. In D59650#1438515 , @JonasToth wrote: > Why not having normal overloads? The analysis for `Stmt` is implemented with > the private methods. Explicit template specialization is a bit overkill and > so easily understood (but not

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

JonasToth added a comment. Why not having normal overloads? The analysis for `Stmt` is implemented with the private methods. Explicit template specialization is a bit overkill and so easily understood (but not too complex in this case either).l Repository: rCTE Clang Tools Extra CHANGES SIN

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri created this revision. lebedev.ri added reviewers: baloghadamsoftware, JonasToth, gribozavr. lebedev.ri added a project: clang-tools-extra. Herald added a subscriber: rnkovacs. Herald added a project: clang. D59466 wants to analyse the `Stmt`, and `Exc