[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

This revision was automatically updated to reflect the committed changes. Closed by commit rL358273: [clangd] Add TemplateArgumentList into Symbol (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59640/new/ https://reviews.llvm.org/D59640 _

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

kadircet updated this revision to Diff 194820. kadircet marked 2 inline comments as done. kadircet added a comment. - Fill in the TemplateSpecializationArgs in all code paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59640/new/ https://reviews

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:566 +printTemplateSpecializationArgs(ND); +S.TemplateSpecializationArgs = TemplateSpecializationArgs; if (Opts.StoreAllDocumentation) kadircet wro

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:566 +printTemplateSpecializationArgs(ND); +S.TemplateSpecializationArgs = TemplateSpecializationArgs; if (Opts.StoreAllDocume

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:566 +printTemplateSpecializationArgs(ND); +S.TemplateSpecializationArgs = TemplateSpecializationArgs; if (Opts.StoreAllDocumentation) Any reason t

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

kadircet added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59640/new/ https://reviews.llvm.org/D59640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

kadircet updated this revision to Diff 191860. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59640/new/ https://reviews.llvm.org/D59640 Files: clang-tools-ex

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

kadircet added a comment. In D59640#1438248 , @ioeric wrote: > should we update YAML? I suppose we are only keeping it alive for the sake of tests, but that seems like an enough reason updating that as well. Comment at: clang-tools-e

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

ioeric added a comment. should we update YAML? Comment at: clang-tools-extra/clangd/index/Symbol.h:48 + /// non-specializations. Example: "" + llvm::StringRef TemplateArgumentList; /// The location of the symbol's definition, if one was found. How about `

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov, gribozavr. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay. Herald added a project: clang. Part of re-landing rC356541 with D59599