efriedma added a comment.
Usually no... I wasn't think about it the last time I reviewed a change to this
file. Patch welcome to just zap it, assuming we have appropriate coverage in
llvm/test/CodeGen/AArch64.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59557
RKSimon added a comment.
I thought we weren't supposed to reference asm codegen in clang tests? (PR24580)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59557/new/
https://reviews.llvm.org/D59557
___
cfe-commits maili
This revision was automatically updated to reflect the committed changes.
Closed by commit rC356517: Fix CodeGen/arm64-microsoft-status-reg.cpp test
(authored by rupprecht, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D59557?vs=191379&id=191390#toc
Repository:
rC Clang
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59557/new/
https://reviews.llvm.org/D59557
___
rupprecht created this revision.
rupprecht added reviewers: arsenm, MatzeB.
Herald added subscribers: cfe-commits, kristof.beyls, javed.absar, wdng.
Herald added a project: clang.
This test is failing after r356499. Update the register selection used in the
test.
Repository:
rG LLVM Github Mo
