PiotrZSL added a comment.
Herald added subscribers: carlosgalvezp, shchenz.
Herald added a project: All.
Looks like this change is responsible for
https://github.com/llvm/llvm-project/issues/59807 and
https://github.com/llvm/llvm-project/issues/62337 issues.
Repository:
rL LLVM
CHANGES SINC
On Tue, Apr 2, 2019 at 10:53 AM Mikael Holmén via Phabricator <
revi...@reviews.llvm.org> wrote:
> uabelho added a comment.
>
> Hi,
>
> I noticed that with this commit I get a whole bunch (~40) of warnings like
> the below when compiling with gcc 7.4:
>
> [10/16] Building CXX object
> tools/clan
uabelho added a comment.
Hi,
I noticed that with this commit I get a whole bunch (~40) of warnings like the
below when compiling with gcc 7.4:
[10/16] Building CXX object
tools/clang/tools/extra/clang-tidy/utils/CMakeFiles/clangTidyUtils.dir/HeaderGuard.cpp.o
In file included from
../tool
This revision was automatically updated to reflect the committed changes.
alexfh marked an inline comment as done.
Closed by commit rL356750: [clang-tidy] Expand modular headers for PPCallbacks
(authored by alexfh, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commi
alexfh updated this revision to Diff 191871.
alexfh marked an inline comment as done.
alexfh added a comment.
- - Update a comment according to the review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59528/new/
https://reviews.llvm.org/D
alexfh marked 3 inline comments as done.
alexfh added inline comments.
Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:166
+Preprocessor->Lex(CurrentToken);
+}
+
gribozavr wrote:
> Haha, so the test that I asked to add did catch a
gribozavr accepted this revision.
gribozavr marked an inline comment as done.
gribozavr added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:166
+Preprocessor->Lex(CurrentToken);
+
alexfh added a comment.
Thank you for the review! I hope I covered all the points.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59528/new/
https://reviews.llvm.org/D59528
___
cfe-commits mailing list
alexfh added inline comments.
Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:24
+ void recordContent(const FileEntry *File,
+ const SrcMgr::ContentCache *ContentCache,
+ llvm::vfs::InMemoryFileSystem &InMemory
alexfh updated this revision to Diff 191703.
alexfh marked 15 inline comments as done.
alexfh added a comment.
- Addressed review comments. Parse code to the end (seems right to do this, but
no specific test that would fail otherwise).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
gribozavr added inline comments.
Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h:32
+
+/// \brief Handles PPCallbacks and replays preprocessing with modules disabled.
+///
replays => re-runs
Repository:
rG LLVM Github Monorepo
CHAN
gribozavr added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidy.h:156
+ virtual void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP,
+ Preprocessor *ModuleExpanderPP) {}
+
Please document that
alexfh updated this revision to Diff 191230.
alexfh added a comment.
- Fix naming.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59528/new/
https://reviews.llvm.org/D59528
Files:
clang-tools-extra/clang-tidy/CMakeLists.txt
clang-tools-extra/cl
alexfh updated this revision to Diff 191227.
alexfh added a comment.
- Fix a typo in the comment. Rearrange paragraphs to make the comment more
readable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59528/new/
https://reviews.llvm.org/D59528
Fil
alexfh created this revision.
alexfh added reviewers: gribozavr, usaxena95, sammccall.
Herald added subscribers: jdoerfert, kbarton, xazax.hun, mgorny, nemanjai.
Herald added a project: clang.
Add a way to expand modular headers for PPCallbacks. Checks can opt-in for this
expansion by overriding t
15 matches
Mail list logo
