[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356802: [clang-tidy] openmp-exception-escape - a new check (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D59466?vs=191911&id=191929#toc Repository: rCTE

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri added a comment. In D59466#1439880 , @aaron.ballman wrote: > Aside from a docs nit, LGTM! Thank you for the review! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59466/new/ https://reviews.llvm

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

aaron.ballman accepted this revision. aaron.ballman added a comment. Aside from a docs nit, LGTM! Comment at: docs/clang-tidy/checks/openmp-exception-escape.rst:13 +structured block. If an exception is not caught in the same structured block +it was thrown in, the behaviour is

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri added inline comments. Comment at: docs/clang-tidy/checks/openmp-exception-escape.rst:10-11 +As per the OpenMP specification, structured block is an executable statement, +possibly compound, with a single entry at the top and a single exit at the +bottom. Which means,

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri updated this revision to Diff 191911. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Last few nits. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59466/new/ https://reviews.llvm.org/D59466 Files: clang-tidy/op

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

aaron.ballman added inline comments. Comment at: clang-tidy/openmp/ExceptionEscapeCheck.cpp:48 +return; + // Similarly, if C++ Exceptions are not enabled, nothing to do. + if (!getLangOpts().CPlusPlus || !getLangOpts().CXXExceptions) lebedev.ri wrote: > aar

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri added inline comments. Comment at: clang-tidy/openmp/ExceptionEscapeCheck.cpp:53 + Finder->addMatcher(ompExecutableDirective( + unless(isStandaloneDirective()), + hasStructuredBlock(stmt().bind("structured-block")))

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri updated this revision to Diff 191892. lebedev.ri marked 15 inline comments as done. lebedev.ri added a comment. Addressed some nits. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59466/new/ https://reviews.llvm.org/D59466 Files: clang-

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

aaron.ballman added inline comments. Comment at: clang-tidy/openmp/ExceptionEscapeCheck.cpp:32 + llvm::StringSet<> IgnoredExceptions; + StringRef(RawIgnoredExceptions).split(IgnoredExceptionsVec, ",", -1, false); + IgnoredExceptions.insert(IgnoredExceptionsVec.begin(), ---

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

gribozavr accepted this revision. gribozavr marked an inline comment as done. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/openmp/ExceptionEscapeCheck.cpp:53 + Finder->addMatcher(ompExecutableDirective( +

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri updated this revision to Diff 191870. lebedev.ri marked 6 inline comments as done. lebedev.ri added a comment. Address some nits. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59466/new/ https://reviews.llvm.org/D59466 Files: clang-tid

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri added inline comments. Comment at: clang-tidy/openmp/ExceptionEscapeCheck.cpp:53 + Finder->addMatcher(ompExecutableDirective( + unless(isStandaloneDirective()), + hasStructuredBlock(stmt().bind("structured-block")))

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tidy/openmp/ExceptionEscapeCheck.cpp:53 + Finder->addMatcher(ompExecutableDirective( + unless(isStandaloneDirective()), + hasStructuredB

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri updated this revision to Diff 191783. lebedev.ri added a comment. Rebased for D59650 changes, NFC. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59466/new/ https://reviews.llvm.org/D59466 Files: clang-

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri updated this revision to Diff 191727. lebedev.ri added a reviewer: gribozavr. lebedev.ri added a comment. Rebased, NFC. Split base ExceptionEscapeCheck refactoring into D59650 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https:/

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri added a comment. In D59466#1434841 , @baloghadamsoftware wrote: > Great work! Thank you! I only have minor comment: did you consider moving the > refactoring of `ExceptionAnalyzer` into a separate (prerequisite) patch? Yes, absolutely, that

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

baloghadamsoftware added a comment. Great work! Thank you! I only have minor comment: did you consider moving the refactoring of `ExceptionAnalyzer` into a separate (prerequisite) patch? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59466/new/ http

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri created this revision. lebedev.ri added reviewers: JonasToth, aaron.ballman, baloghadamsoftware. lebedev.ri added projects: clang-tools-extra, OpenMP. Herald added subscribers: jdoerfert, guansong, rnkovacs, xazax.hun, mgorny. Herald added a project: clang. Finally, we are here! Analyz