This revision was automatically updated to reflect the committed changes.
Closed by commit rL358695: [analyzer][NFC] Prefer binary searches in
CheckerRegistry (authored by Szelethus, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
baloghadamsoftware accepted this revision.
baloghadamsoftware added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59459/new/
https://reviews.llvm.org/D59459
___
cfe-commits m
Szelethus updated this revision to Diff 195358.
Szelethus added a comment.
Avoid past-the-end iterator dereference, add it to the assert.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59459/new/
https://reviews.llvm.org/D59459
Files:
include/clang/StaticAnalyzer/Frontend/CheckerRegis
Szelethus marked an inline comment as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:70
+ Collection, Info,
+ FullNameLT{});
+}
baloghadamsoftware wrote:
> Please note that `llvm::lower_bound()` uses `
Szelethus updated this revision to Diff 194768.
Szelethus added a comment.
Change asserts according to reviewer feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59459/new/
https://reviews.llvm.org/D59459
Files:
include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h
lib/Stat
baloghadamsoftware requested changes to this revision.
baloghadamsoftware added inline comments.
This revision now requires changes to proceed.
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:70
+ Collection, Info,
+ FullNameLT{});
+}
Please
Szelethus created this revision.
Szelethus added reviewers: xazax.hun, NoQ, baloghadamsoftware, rnkovacs.
Szelethus added a project: clang.
Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy,
mikhail.ramalho, a.sidorin, szepet, whisperity.
Szelethus added a parent revis