akhuang added a comment.
@arichardson Will add you next time, sorry I didn't do so on this one!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
___
cfe-commits mailing list
cf
arichardson added a comment.
@akhuang Thanks for getting this committed. Since it seems like a lot of this
is taken from my script, could you please add me as a reviewer for the next
patch so that I know which bits still need to be upstreamed?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
This revision was automatically updated to reflect the committed changes.
Closed by commit rC356636: creduce-clang-crash.py: preprocess file + reduce
commandline (authored by gbiv, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D59440?vs=191598&id=191615#toc
Repository:
rC
george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.
LGTM; thanks again!
Will land shortly
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
__
akhuang updated this revision to Diff 191598.
akhuang added a comment.
style nits, fixed thing in getting path to clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index: clang/utils/creduce-clang
george.burgess.iv added a comment.
Just a few style nits for you, and this LGTM. I assume rnk and
serge-sans-paille are content, so I'm happy to check this in for you once these
are addressed.
Thanks!
Comment at: clang/utils/creduce-clang-crash.py:64
crash_output, _ = p.c
akhuang updated this revision to Diff 191409.
akhuang added a comment.
style things
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index: clang/utils/creduce-clang-crash.py
==
serge-sans-paille added inline comments.
Comment at: clang/utils/creduce-clang-crash.py:45
+ result = []
+ for i, arg in enumerate(cmd):
+if arg.startswith('$'):
Useless enumerate here. You could even use a list comprehension here
```
return ' '.join(arg i
akhuang marked an inline comment as done.
akhuang added inline comments.
Comment at: clang/utils/creduce-clang-crash.py:106-117
+ # Check that an empty file is not interesting
+ # file_to_reduce is hardcoded into the test, so this is a roundabout
+ # way to run it on an empty
akhuang updated this revision to Diff 191217.
akhuang marked 2 inline comments as done.
akhuang added a comment.
Fixed typo where it was writing the abspath of the file to the interestingness
test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
akhuang updated this revision to Diff 191199.
akhuang marked an inline comment as done.
akhuang added a comment.
fixed array copy mistake
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index: clang/u
rnk added a comment.
Aside from the buglet, I'm happy with this, but I wanted to wait until
@george.burgess.iv takes a look.
Comment at: clang/utils/creduce-clang-crash.py:44
+
+def quote_cmd(cmd):
+ for i, arg in enumerate(cmd):
This modifies cmd in place, s
akhuang updated this revision to Diff 191192.
akhuang added a comment.
Modify interestingness test to take file as input
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index: clang/utils/creduce-clan
rnk added inline comments.
Comment at: clang/utils/creduce-clang-crash.py:106-117
+ # Check that an empty file is not interesting
+ # file_to_reduce is hardcoded into the test, so this is a roundabout
+ # way to run it on an empty file
+ _, tmpfile = tempfile.mkstemp()
+ _,
akhuang updated this revision to Diff 191128.
akhuang added a comment.
fix some typos
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index: clang/utils/creduce-clang-crash.py
akhuang updated this revision to Diff 190929.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59440/new/
https://reviews.llvm.org/D59440
Files:
clang/utils/creduce-clang-crash.py
Index: clang/utils/creduce-clang-crash.py
==
akhuang created this revision.
akhuang added reviewers: rnk, george.burgess.iv.
Herald added a reviewer: serge-sans-paille.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
-try to preprocess the file before reducing
-try to remove some command line arguments
-now requires a
17 matches
Mail list logo
