[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: test/Headers/max_align.c:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s +// expected-no-diagnostics lebedev.ri wrote: > hubert.reinterpretcast wrote: > > We may need to explicitly specify C11. It also seem

[PATCH] D59048: Add AIX Target Info

lebedev.ri added inline comments. Comment at: test/Headers/max_align.c:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s +// expected-no-diagnostics hubert.reinterpretcast wrote: > We may need to explicitly specify C11. It also seems that we should XFAIL > Windows

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: test/Headers/max_align.c:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s +// expected-no-diagnostics We may need to explicitly specify C11. It also seems that we should XFAIL Windows targets. Repository:

[PATCH] D59048: Add AIX Target Info

jasonliu added a comment. I'm seeing some build bot failures because of the newly added test case: max_align.c. So I reverted the previous committed change. Please fix the test case and let me know so that I can help you commit again. Repository: rC Clang CHANGES SINCE LAST ACTION https:/

[PATCH] D59048: Add AIX Target Info

This revision was automatically updated to reflect the committed changes. Closed by commit rC356060: Add AIX Target Info (authored by jasonliu, committed by ). Changed prior to commit: https://reviews.llvm.org/D59048?vs=190133&id=190425#toc Repository: rC Clang CHANGES SINCE LAST ACTION h

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a subscriber: WuZhao. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. I think all comments have been addressed or otherwise responded to. @jasonliu: Since this patch is dependent on

[PATCH] D59048: Add AIX Target Info

andusy updated this revision to Diff 190133. andusy added a comment. - Fixed comment. - Checked that `_LP64`, `__LP64__`, and `__64BIT__` aren't defined in 32 bit mode. - Checked that `_ILP32` and `__ILP32__` aren't defined in 64 bit mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:640 + +// Define _WCHAR_T when it is a fundamental type (i.e., for C++ without -fno-wchar). +if (Opts.CPlusPlus && Opts.WChar) { Line is longer than 80 characte

[PATCH] D59048: Add AIX Target Info

andusy marked 2 inline comments as done. andusy added inline comments. Comment at: clang/test/CodeGen/arm-aapcs-zerolength-bitfield.c:5 +// RUN: %clang_cc1 -triple powerpc-ibm-aix7.1.0.0 %s -verify +// expected-no-diagnostics This file is pending a name change.

[PATCH] D59048: Add AIX Target Info

andusy marked 7 inline comments as done. andusy added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:641 +} + } + hubert.reinterpretcast wrote: > D18360 sets `_THREAD_SAFE` to `1` when `-pthread` is specified. I believe > that to be correc

[PATCH] D59048: Add AIX Target Info

andusy updated this revision to Diff 189890. andusy added a comment. Herald added a subscriber: javed.absar. - Updated comments - Added testing for `UseZeroLengthBitfieldAlignment` - Defined `_THREAD_SAFE ` when `-pthread` is enabled - Check for definition of `__LP64__ ` and `_LP64 ` macros CH

[PATCH] D59048: Add AIX Target Info

sfertile added inline comments. Comment at: clang/test/Preprocessor/init.c:6420 +// PPC64-AIX:#define _LONG_LONG 1 +// PPC64-AIX:#define _POWER 1 +// PPC64-AIX:#define __64BIT__ 1 hubert.reinterpretcast wrote: > hubert.reinterpretcast wrote: > > apaprocki wrote:

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: clang/test/Preprocessor/init.c:6420 +// PPC64-AIX:#define _LONG_LONG 1 +// PPC64-AIX:#define _POWER 1 +// PPC64-AIX:#define __64BIT__ 1 hubert.reinterpretcast wrote: > apaprocki wrote: > > XL on AIX emits

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:626 + +// FIXME: Define AIX OS-Version Macros +Builder.defineMacro("_AIX"); apaprocki wrote: > hubert.reinterpretcast wrote: > > Comments should be full sent

[PATCH] D59048: Add AIX Target Info

apaprocki added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:626 + +// FIXME: Define AIX OS-Version Macros +Builder.defineMacro("_AIX"); hubert.reinterpretcast wrote: > Comments should be full sentences (with periods). Please updat

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added a subscriber: rsmith. hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:626 + +// FIXME: Define AIX OS-Version Macros +Builder.defineMacro("_AIX"); Comments should be full senten

[PATCH] D59048: Add AIX Target Info

andusy created this revision. andusy added reviewers: apaprocki, chandlerc, hubert.reinterpretcast, jasonliu, xingxue, sfertile. Herald added subscribers: jsji, jfb, kbarton, nemanjai. Herald added a project: clang. A first pass over platform-specific properties of the C API/ABI on AIX for both