Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-07-01 Thread Matt Arsenault via cfe-commits
arsenm closed this revision. arsenm added a comment. r274370 http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-30 Thread Hal Finkel via cfe-commits
hfinkel accepted this revision. hfinkel added a reviewer: hfinkel. hfinkel added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-30 Thread Matt Arsenault via cfe-commits
arsenm added a comment. ping http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-27 Thread Matt Arsenault via cfe-commits
arsenm added a comment. ping http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-21 Thread Matt Arsenault via cfe-commits
arsenm updated this revision to Diff 61472. arsenm added a comment. Attach right diff http://reviews.llvm.org/D5896 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins.c Index: test/CodeGen/builtins.c === --- test/CodeGen/b

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-21 Thread Matt Arsenault via cfe-commits
arsenm updated this revision to Diff 61468. arsenm added a comment. It appears removing the F isn't actually necessary, unremove it http://reviews.llvm.org/D5896 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins.c Index: test/CodeGen/builtins.c =

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-21 Thread Matt Arsenault via cfe-commits
arsenm added a comment. In http://reviews.llvm.org/D5896#463883, @hfinkel wrote: > Why are you removing 'F' from all of the builtin definitions? And if you need > to, why are you not removing them from copysign? That marks them as emitting a libcall. It should also be removed from copysign h

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-21 Thread Hal Finkel via cfe-commits
hfinkel added a comment. Why are you removing 'F' from all of the builtin definitions? And if you need to, why are you not removing them from copysign? http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-21 Thread Matt Arsenault via cfe-commits
arsenm updated this revision to Diff 61432. arsenm added a comment. Update for trunk http://reviews.llvm.org/D5896 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins.c Index: test/CodeGen/builtins.c