This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE355679: [clangd] Make sure constructors do not reference
class (authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D58815?vs=189832&id=189833#toc
Repository:
rC
kadircet updated this revision to Diff 189832.
kadircet marked an inline comment as done.
kadircet added a comment.
- Address comments
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58815/new/
https://reviews.llvm.org/D58815
Files:
clangd/XRefs.cp
gribozavr accepted this revision.
gribozavr added inline comments.
Comment at: clangd/XRefs.cpp:160
+if (Roles & static_cast(index::SymbolRole::NameReference))
+ return true;
if (Loc == SearchedLocation) {
Maybe add a blank line so that it is clear
kadircet updated this revision to Diff 189831.
kadircet added a comment.
- Make use of NameReference symbol role
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58815/new/
https://reviews.llvm.org/D58815
Files:
clangd/XRefs.cpp
clangd/index/Symbo
kadircet updated this revision to Diff 188878.
kadircet marked an inline comment as done.
kadircet added a comment.
Re-arrange test location
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58815/new/
https://reviews.llvm.org/D58815
Files:
unittests
gribozavr accepted this revision.
gribozavr added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/clangd/XRefsTests.cpp:1361
+}
+ )cpp",
};
Add the new test right after the "Method call" test, to keep it gro
kadircet created this revision.
kadircet added a reviewer: gribozavr.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Herald added a project: clang.
kadircet added a parent revision: D58814: [clang][Index] Constructors and
Destructors do not reference cla
