This revision was automatically updated to reflect the committed changes.
Closed by commit rL357363: COMDAT-fold block descriptors. (authored by
theraven, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D58
DHowett-MSFT updated this revision to Diff 189193.
DHowett-MSFT added a comment.
Fixed corrupted patch. I know that the -str test case is not the _ideal_
location for the comdat test, but it is the only test whose invariants failed
(the IR for the descriptor definition now contains `comdat, alig
DHowett-MSFT updated this revision to Diff 189183.
DHowett-MSFT added a comment.
This change caused a test to fail, so I took the opportunity to augment the
test with COMDAT entry.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58807/new/
https://r
theraven added a comment.
It would probably benefit from a test so that we don't regress.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58807/new/
https://reviews.llvm.org/D58807
___
cfe-commits mailin
theraven accepted this revision.
theraven added a comment.
This revision is now accepted and ready to land.
Looks good to me. On ELF and Mach-O, I think we get the equivalent behaviour
automatically from the ODR linkage type. I'd really like to see linkage type
and COMDAT made orthogonal, but
DHowett-MSFT created this revision.
DHowett-MSFT added a project: clang.
Herald added a subscriber: cfe-commits.
Without this change, linking multiple objects containing block
descriptors together on Windows will generate duplicate symbol errors.
Repository:
rG LLVM Github Monorepo
https://re
