[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

2019-04-02 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. One heuristic that we could use is to ignore inherited data members optionally. Does that sound any good? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 _

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

2019-03-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D58573#1437749 , @Szelethus wrote: > Ping, @NoQ, if we settled on `optin.cplusplus`, would you be fine with this > patch? Yup, totally! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ h

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

2019-03-29 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Ping^2 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

2019-03-21 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Ping, @NoQ, if we settled on `optin.cplusplus`, would you be fine with this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___ cfe-commits

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

2019-03-12 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. In case no bug reports //against// the checker are reported on the mailing list or Bugzilla, I wholeheartedly agree with kicking the ball here. As for the package, perhaps we could go into `optin.bugprone` or `optin.conventions`? (These are new package names...) Re

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

2019-03-10 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D58573#1422198 , @NoQ wrote: > Also, hmm, how about the following heuristics (looked at the positive in > `rtags` and thought about this): > > - if the field is public, don't warn (the structure seems to be used simply > as

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

2019-03-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. At a glance, it seems as if these are great findings for a hardening effort, but most of these don't look like immediate bugs (had a look at 10 or so), so i guess i'd suggest `optin.cplusplus`, at least for now. Also, hmm, how about the following heuristics (looked at the p

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

2019-03-03 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Herald added a subscriber: Charusso. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

2019-02-23 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: dcoughlin, NoQ, xazax.hun, rnkovacs, whisperity, a.sidorin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, szepet, baloghadamsoftware. I've tested the checker on