[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

2019-02-21 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. r354624 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58526/new/ https://reviews.llvm.org/D58526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

2019-02-21 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 187849. arsenm added a comment. Undelete run line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58526/new/ https://reviews.llvm.org/D58526 Files: lib/Driver/ToolChains/AMDGPU.cpp test/Driver/amdgpu-features.c Index: test/Driver/amdgpu-features

[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

2019-02-21 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58526/new/ https://reviews.llvm.org/D58526 ___ cfe-commits mailing list cfe-commi

[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

2019-02-21 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
kzhuravl added inline comments. Comment at: test/Driver/amdgpu-features.c:4 // CHECK-MAMDGPU-DEBUGGER-ABI-0-0: the clang compiler does not support '-mamdgpu-debugger-abi=0.0' - -// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-abi=1.0 %s -o

[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

2019-02-21 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: yaxunl, kzhuravl, t-tye. Herald added subscribers: jdoerfert, tpr, dstuttard, nhaehnle, wdng, jvesely. Keep the flag around for compatability. https://reviews.llvm.org/D58526 Files: lib/Driver/ToolChains/AMDGPU.cpp test/Driver/amdgpu-fea