alexfh abandoned this revision.
alexfh added a comment.
I've found an alternative way to deal with PPCallbacks when analyzing code in
modular mode. See https://reviews.llvm.org/D59528. Abandoning this revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
sammccall added inline comments.
Comment at: clang/include/clang/Lex/PPCallbacks.h:346
+
+ virtual void setPreprocessor(Preprocessor *preprocessor) {
+preprocessor_ = preprocessor;
alexfh wrote:
> sammccall wrote:
> > This seems pretty tangly from a layering
alexfh marked an inline comment as done.
alexfh added inline comments.
Comment at: clang/include/clang/Lex/PPCallbacks.h:346
+
+ virtual void setPreprocessor(Preprocessor *preprocessor) {
+preprocessor_ = preprocessor;
sammccall wrote:
> This seems pretty ta
sammccall added inline comments.
Comment at: clang/include/clang/Lex/PPCallbacks.h:346
+
+ virtual void setPreprocessor(Preprocessor *preprocessor) {
+preprocessor_ = preprocessor;
This seems pretty tangly from a layering point of view, giving each object a
alexfh added a comment.
Friendly ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58278/new/
https://reviews.llvm.org/D58278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
usaxena95 added a comment.
+cc myself
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58278/new/
https://reviews.llvm.org/D58278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
alexfh created this revision.
alexfh added reviewers: bkramer, klimek, rsmith.
Herald added subscribers: jdoerfert, jsji, kbarton, nemanjai.
Herald added a project: clang.
When a clang tool runs on a translation unit that uses modular headers, no
PPCallbacks will be invoked for the code in the mod
