[PATCH] D58216: Support attribute used in member funcs of class templates II

davezarzycki added a comment. https://bugs.llvm.org/show_bug.cgi?id=41016 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58216/new/ https://reviews.llvm.org/D58216 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler added a comment. I definitely understand how the diagnostic can be confusing. However, it's the same diagnostic gcc provides too, so gcc users wouldn't be surprised. But you're right this can be improved by at least mentioning the attribute used in the diagnostic message. There's no bu

[PATCH] D58216: Support attribute used in member funcs of class templates II

davezarzycki added a comment. I've got a patch pending for Swift. That being said, the clang diagnostics leave something to be desired. If `__attribute__((used))` on definitions is sloppy at best or wrong at worst, then that should have a warning/error. Want a bug report? Or does one exist alre

[PATCH] D58216: Support attribute used in member funcs of class templates II

bob.wilson added a comment. OK, that doesn't sound like it will be a problem Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58216/new/ https://reviews.llvm.org/D58216 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D58216: Support attribute used in member funcs of class templates II

davezarzycki added a subscriber: bob.wilson. davezarzycki added a comment. I can't get Swift top-of-tree to build with gcc (8.3.1 20190223 (Red Hat 8.3.1-2)), and I doubt that it is supported, but I could be wrong. In any case, the requested change to the Swift compiler source sounds reasonable

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler added a comment. I'm not an expert in swift either. I'll wait for @davezarzycki input on what's happening, but I suspect the code base is indeed incompatible with gcc due to the nature of the error they experienced. This testcase is creduce-d from what I observed in swift. Repositor

[PATCH] D58216: Support attribute used in member funcs of class templates II

aaron.ballman added a comment. In D58216#1420149 , @rafauler wrote: > Both approaches make sense to me. I'll re-land the previous patch in favor of > gcc compatibility, since the semantics of attribute used in member functions > of class templates were f

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler added a subscriber: davezarzycki. rafauler added a comment. Both approaches make sense to me. I'll re-land the previous patch in favor of gcc compatibility, since the semantics of attribute used in member functions of class templates were first implemented in gcc. @davezarzycki Heads

[PATCH] D58216: Support attribute used in member funcs of class templates II

aaron.ballman added a comment. In D58216#1414864 , @modocache wrote: > Friendly ping! @aaron.ballman it looks like you accepted D56928 > , could you take a look at this as well? Sorry for the delay -- I was at WG21 meeti

[PATCH] D58216: Support attribute used in member funcs of class templates II

modocache added a comment. Friendly ping! @aaron.ballman it looks like you accepted D56928 , could you take a look at this as well? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58216/new/ https://reviews.llvm.org/D58216 _

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler created this revision. rafauler added reviewers: rsmith, ldionne, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: clang. As PR17480 describes, clang does not support the used attribute for member functions of class templates. This means that if the member func