[PATCH] D58062: Support framework import/include auto-completion

dgoldman closed this revision. dgoldman added a comment. Closed via rL355008 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062 ___ cfe-commit

[PATCH] D58062: Support framework import/include auto-completion

dgoldman added a comment. In D58062#1399499 , @sammccall wrote: > Great, thank you! Want me to land this? > > (You can certainly get your own commit access at this point if you like: > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access and

[PATCH] D58062: Support framework import/include auto-completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great, thank you! Want me to land this? (You can certainly get your own commit access at this point if you like: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access and po

[PATCH] D58062: Support framework import/include auto-completion

dgoldman marked 3 inline comments as done. dgoldman added a comment. added test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D58062: Support framework import/include auto-completion

dgoldman updated this revision to Diff 186904. dgoldman added a comment. - Add test and fix subfolder bug Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/includ

[PATCH] D58062: Support framework import/include auto-completion

sammccall added a comment. Code looks good apart from one case where we encounter Foo.framework/Subdir1/Subdir2. Can you add a test to `clang/test/CodeCompletion`? `included-files.cpp` has the existing tests, not sure if you can add them there or it needs to be an obj-c file for framework incl

[PATCH] D58062: Support framework import/include auto-completion

dgoldman updated this revision to Diff 186524. dgoldman marked 9 inline comments as done. dgoldman added a comment. Herald added a subscriber: jdoerfert. - Misc fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062 Files:

[PATCH] D58062: Support framework import/include auto-completion

sammccall added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:8375 + auto AddFilesFromIncludeDir = [&](StringRef IncludeDir, bool IsSystem, +bool isFramework) { +bool stripFrameworkSuffix = false; nit: `IsFram

[PATCH] D58062: Support framework import/include auto-completion

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Frameworks filesystem representations: UIKit.framework/Headers/%header% Framework import format: #import Thus the completion code must map the input