Anastasia abandoned this revision.
Anastasia added a comment.
Due to my recent commits I had to changed this slightly so it is now under a
new review: https://reviews.llvm.org/D62914
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58060/new/
https://reviews.llvm.org/D58060
___
Anastasia added a comment.
@rjmccall or @ebevhan do you have any more feedback for this patch?
Btw, it has now dependency with https://reviews.llvm.org/D61318
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58060/new/
https://reviews.llvm.org/D58060
___
Anastasia updated this revision to Diff 189351.
Anastasia marked an inline comment as done.
Anastasia added a comment.
Un-commented the line in the test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58060/new/
https://reviews.llvm.org/D58060
Files:
include/clang/Basic/DiagnosticSemaK
Anastasia added inline comments.
Comment at: test/SemaOpenCLCXX/address-space-references.cl:7
+// can't detect this case and therefore fails.
+//int bar(const unsigned int &i);
+
ebevhan wrote:
> Is there a reason the declaration is commented out? If it's just a
ebevhan added inline comments.
Comment at: test/SemaOpenCLCXX/address-space-references.cl:7
+// can't detect this case and therefore fails.
+//int bar(const unsigned int &i);
+
Is there a reason the declaration is commented out? If it's just a problem with
the r
Anastasia updated this revision to Diff 189306.
Anastasia retitled this revision from "Fix diagnostic for addr spaces in
static_cast" to "Fix diagnostic for addr spaces in reference binding".
Anastasia edited the summary of this revision.
Anastasia added a comment.
- Fixed incorrect diagnostic in
