[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin added a comment. In D57798#1386470 , @sbc100 wrote: > How does this relate to the existing ` -mattr=+atomics` of llc? Will it also > result in `attributes #0 = { "target-features"="+atomics" }` in the bitcode? Yes Repository: rL LLVM CHAN

[PATCH] D57798: [WebAssembly] Add atomics target option

sbc100 added a comment. How does this relate to the existing ` -mattr=+atomics` of llc? Will it also result in `attributes #0 = { "target-features"="+atomics" }` in the bitcode? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/ https://reviews.llvm.org/D

[PATCH] D57798: [WebAssembly] Add atomics target option

This revision was automatically updated to reflect the committed changes. Closed by commit rL353260: [WebAssembly] Add atomics target option (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTIO

[PATCH] D57798: [WebAssembly] Add atomics target option

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Basic/Targets/WebAssembly.cpp:172 +} +if (Feature == "0atomics") { + HasAtomics = false; tlively wrote: > -atomics You wo

[PATCH] D57798: [WebAssembly] Add atomics target option

tlively added inline comments. Comment at: lib/Basic/Targets/WebAssembly.cpp:172 +} +if (Feature == "0atomics") { + HasAtomics = false; -atomics Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/ https://revie

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin updated this revision to Diff 185454. aheejin added a comment. - Fix typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/ https://reviews.llvm.org/D57798 Files: include/clang/Driver/Options.td lib/Basic/Targets/WebAssembly.cpp lib/Basic/Ta

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D57798 Files: include/clang/Driver/Options.td lib/Basic/Ta