[PATCH] D57527: Do not copy floating pointer format from aux target

2019-01-31 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D57527#1379088 , @yaxunl wrote: > In D57527#1379065 , @rjmccall wrote: > > > Okay, so you silently have an incompatible ABI for anything in the system > > headers that mentions `long do

[PATCH] D57527: Do not copy floating pointer format from aux target

2019-01-31 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D57527#1379065 , @rjmccall wrote: > Okay, so you silently have an incompatible ABI for anything in the system > headers that mentions `long double`. Do you have any plans to address or > work around that, or is the hope that i

[PATCH] D57527: Do not copy floating pointer format from aux target

2019-01-31 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Okay, so you silently have an incompatible ABI for anything in the system headers that mentions `long double`. Do you have any plans to address or work around that, or is the hope that it just doesn't matter? I feel like this should be a special case for AMDGPU rather

[PATCH] D57527: Do not copy floating pointer format from aux target

2019-01-31 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: rjmccall. rC352620 caused regressions because it copied floating point format from aux target. floating point format decides whether extended long double is supported. It is x86_fp80 on x86 but IEEE double